fix: clarify Python pytest failure messages - #24
Open
kbuffardi wants to merge 2 commits into
Open
Conversation
Keep custom assertion messages intact and retain default pytest diagnostics for failed Python tests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve the upstream Python error-handling contract while retaining detailed pytest failure diagnostics. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Improves Python pytest result parsing so learners receive more constructive, non-truncated failure feedback (custom assertion messages and full E ... diagnostic lines), aligning with Issue #23’s request for clearer outcome messaging.
Changes:
- Reworked
parsePytestOutputto extract per-failure error message blocks (including multiline assertion details) and distinguish failures vs errors for counting. - Added dependency-free Node regression tests covering custom assertion messages, default assertion diffs, exceptions, multiple failures, collection errors, and mixed failure/error runs.
- Updated
npm testto run the new regression suite.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| executor.js | Updates pytest output parsing to preserve detailed assertion/exception diagnostics and count errors alongside failures. |
| test/executor.test.js | Adds Node-based regression tests for pytest parsing behavior across failure/error scenarios. |
| package.json | Wires npm test to run the new regression tests. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| assertionSource: '', | ||
| errorLines: [], | ||
| finishedErrors: false, | ||
| isError: /\bERROR\b/.test(failureHeader[1]), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23
Summary
Testing