Skip to content

chore: remove the 'check-go-format' make goal - #522

Merged
xcoulon merged 1 commit into
masterfrom
remove-check-go-code-goal
Aug 7, 2026
Merged

chore: remove the 'check-go-format' make goal#522
xcoulon merged 1 commit into
masterfrom
remove-check-go-code-goal

Conversation

@xcoulon

@xcoulon xcoulon commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

not needed anymore, covered by golangci-lint

Signed-off-by: Xavier Coulon xcoulon@redhat.com

Summary by CodeRabbit

  • Chores
    • Removed the check-go-format build command and its formatting validation step.

not needed anymore, covered by golangci-lint

Signed-off-by: Xavier Coulon <xcoulon@redhat.com>
@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown

Walkthrough

The change removes the check-go-format Make target from make/go.mk, including its gofmt validation and error-reporting commands.

Changes

Go format target removal

Layer / File(s) Summary
Remove Go format validation target
make/go.mk
Removes the check-go-format target and its gofmt validation pipeline.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested labels: chore

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description states the reason for the change but omits the required ## Description and ## Checks sections and all checklist responses. Add the required template sections and answer each check, including whether make generate was run and whether other projects changed.
✅ Passed checks (4 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly describes the removal of the check-go-format Make goal, which matches the changeset.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch remove-check-go-code-goal

Comment @coderabbitai help to get the list of available commands.

@sonarqubecloud

sonarqubecloud Bot commented Aug 7, 2026

Copy link
Copy Markdown

@coderabbitai coderabbitai Bot added the chore Routine repo or tooling maintenance label Aug 7, 2026
@xcoulon xcoulon changed the title chore: remove the 'check-go-code' make goal chore: remove the 'check-go-format' make goal Aug 7, 2026
@xcoulon
xcoulon merged commit e29da2f into master Aug 7, 2026
5 of 6 checks passed
@xcoulon
xcoulon deleted the remove-check-go-code-goal branch August 7, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore Routine repo or tooling maintenance

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants