Skip to content

Increase hardcoded control frame read/write timeouts to 20 sec #568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bbrks wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Increase hardcoded control frame read/write timeouts to 20 sec #568

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion read.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ func (c *Conn) handleControl(ctx context.Context, h header) (err error) {
return err
}

ctx, cancel := context.WithTimeout(ctx, time.Second*5)
ctx, cancel := context.WithTimeout(ctx, time.Second*20)
defer cancel()

b := c.readControlBuf[:h.payloadLength]
Expand Down
2 changes: 1 addition & 1 deletion write.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -274,7 +274,7 @@ func (mw *msgWriter) close() {
}

func (c *Conn) writeControl(ctx context.Context, opcode opcode, p []byte) error {
ctx, cancel := context.WithTimeout(ctx, time.Second*5)
ctx, cancel := context.WithTimeout(ctx, time.Second*20)
defer cancel()

_, err := c.writeFrame(ctx, true, false, opcode, p)
Expand Down
Loading