Repository navigation
chore(deps): bump x/net v0.63.0, google api v0.316.0 and genproto rpc - #930
Conversation
golang.org/x/net v0.63.0, google.golang.org/api v0.316.0 and google.golang.org/genproto/googleapis/rpc v0.0.0-20261118221215-c8830f628b3f. cloud.google.com/go/auth stays at v0.24.4 (#422): api v0.316.0 asks for an older auth pseudo-version. Refs #911 _Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `xhigh`_ Change-Id: I13daa2e4a5eff67460739715e53596159fadd46a Signed-off-by: Thomas Kosiewski <tk@coder.com>
|
@codex review |
|
@codex security review |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Another round soon, please! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
🛡️ Codex Security ReviewSecurity review completed. No security issues were found in this pull request. Reviewed commit: Only the user who started this review can view the report in Codex. ℹ️ About Codex security reviews in GitHubThis is an experimental Codex feature. Security reviews are triggered when:
Once complete, Codex will leave suggestions, or a comment if no findings are found. |
|
Verification at head
Lane environment: go1.27.4, git 2.55.0, git-lfs 3.8.1, host load 2 to 29. Generated with |
Why
Issue #911 item 4, from the Nov 20 dependency audit: move golang.org/x/net, google.golang.org/api and genproto's googleapis/rpc to their current releases, and keep cloud.google.com/go/auth at v0.24.4 (#422).
What changed
cloud.google.com/go/auth stays at v0.24.4. api v0.316.0 asks for the older pseudo-version v0.24.1-0.20261001053825-dbc26066f70a, so the explicit v0.24.4 pin from #422 still wins and
go mod tidykeeps it. x/net v0.63.0 requires x/crypto v0.59.0, x/sys v0.50.0, x/text v0.44.0 and x/term v0.48.0, which the module graph already has, so nothing else moves. go.sum changes by 6 added and 6 removed lines, the old and new hashes. vendor/ is regenerated withgo mod vendor.Scope
All three modules are in the server binary: gRPC imports
x/net/http2and genproto's rpc packages, and gax-go importsgoogleapi. The vendor diff is one source file,golang.org/x/net/http2/transport_wrap.go. Its build taggo1.27 && !http2legacycompiles it with Go 1.27.4. It changeshttp2.Transport, which no code in the binary uses, because gRPC uses only http2's framer and hpack code. The change adds a hook that a future net/http can use to report a connection's active streams. Go 1.27.4's net/http never sets that hook, so a caller would take the fallback branch, which gives the same values as v0.62.0 for open connections.The vendored packages of api (
googleapi,internal/third_party/uritemplates) and of genproto rpc (code,errdetails,status) have no source change; onlyvendor/modules.txtmoves. api v0.316.0 only regenerates discovery clients that openstorage does not vendor.Blast Radius
No behaviour change is expected at run time: no code in the binary calls the changed
http2.Transport. The package list ofgo list -deps ./cmd/openstorageis unchanged.Verification
go mod verify,go build ./...,go vetwith test files for linux and darwin on amd64 and arm64, and golangci-lint 2.15.0 pass.Refs #911
Generated with
xum• Model:anthropic:claude-opus-5-5• Thinking:xhigh