Skip to content

chore(deps): bump x/net v0.63.0, google api v0.316.0 and genproto rpc - #930

Merged
ThomasK33 merged 1 commit into
mainfrom
issue911-xnet-gapi
Nov 20, 2026
Merged

ThomasK33 merged 1 commit into
mainfrom
issue911-xnet-gapi

Conversation

@ThomasK33

@ThomasK33 ThomasK33 commented Nov 20, 2026 •

Copy link
Copy Markdown
Member

Why

Issue #911 item 4, from the Nov 20 dependency audit: move golang.org/x/net, google.golang.org/api and genproto's googleapis/rpc to their current releases, and keep cloud.google.com/go/auth at v0.24.4 (#422).

What changed

Module From To
golang.org/x/net v0.62.0 v0.63.0
google.golang.org/api v0.315.0 v0.316.0
google.golang.org/genproto/googleapis/rpc v0.0.0-20261104224025-d1e00e9f33ab v0.0.0-20261118221215-c8830f628b3f

cloud.google.com/go/auth stays at v0.24.4. api v0.316.0 asks for the older pseudo-version v0.24.1-0.20261001053825-dbc26066f70a, so the explicit v0.24.4 pin from #422 still wins and go mod tidy keeps it. x/net v0.63.0 requires x/crypto v0.59.0, x/sys v0.50.0, x/text v0.44.0 and x/term v0.48.0, which the module graph already has, so nothing else moves. go.sum changes by 6 added and 6 removed lines, the old and new hashes. vendor/ is regenerated with go mod vendor.

Scope

All three modules are in the server binary: gRPC imports x/net/http2 and genproto's rpc packages, and gax-go imports googleapi. The vendor diff is one source file, golang.org/x/net/http2/transport_wrap.go. Its build tag go1.27 && !http2legacy compiles it with Go 1.27.4. It changes http2.Transport, which no code in the binary uses, because gRPC uses only http2's framer and hpack code. The change adds a hook that a future net/http can use to report a connection's active streams. Go 1.27.4's net/http never sets that hook, so a caller would take the fallback branch, which gives the same values as v0.62.0 for open connections.

The vendored packages of api (googleapi, internal/third_party/uritemplates) and of genproto rpc (code, errdetails, status) have no source change; only vendor/modules.txt moves. api v0.316.0 only regenerates discovery clients that openstorage does not vendor.

Blast Radius

No behaviour change is expected at run time: no code in the binary calls the changed http2.Transport. The package list of go list -deps ./cmd/openstorage is unchanged.

Verification

  • go mod verify, go build ./..., go vet with test files for linux and darwin on amd64 and arm64, and golangci-lint 2.15.0 pass.
  • golang/net, googleapis/google-api-go-client and googleapis/go-genproto have no published repository advisory.
  • The PostgreSQL and local-backend race lanes, a real-server smoke and CI pass at this head. The evidence is in a PR comment.

Refs #911


Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: xhigh

golang.org/x/net v0.63.0, google.golang.org/api v0.316.0 and
google.golang.org/genproto/googleapis/rpc
v0.0.0-20261118221215-c8830f628b3f. cloud.google.com/go/auth stays
at v0.24.4 (#422): api v0.316.0 asks for an older auth pseudo-version.

Refs #911

_Generated with [`xum`](https://github.com/coder/xum) • Model: `anthropic:claude-opus-5-5` • Thinking: `xhigh`_

Change-Id: I13daa2e4a5eff67460739715e53596159fadd46a
Signed-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33

Copy link
Copy Markdown
Member Author

@codex review

@ThomasK33

Copy link
Copy Markdown
Member Author

@codex security review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-20T16:42:01.448160Z f934f7c Manual request
🔒 Security Review ✅ Completed 2026-11-20T16:43:38.951200Z f934f7c Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: f934f7c202

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@chatgpt-codex-connector

Copy link
Copy Markdown

🛡️ Codex Security Review

Security review completed. No security issues were found in this pull request.

Reviewed commit: f934f7c202

View security finding report

Only the user who started this review can view the report in Codex.

ℹ️ About Codex security reviews in GitHub

This is an experimental Codex feature. Security reviews are triggered when:

  • You comment "@codex security review"
  • A regular code review gets triggered (for example, "@codex review" or when a PR is opened), and you’re opted in so security review runs alongside code review

Once complete, Codex will leave suggestions, or a comment if no findings are found.

@ThomasK33

Copy link
Copy Markdown
Member Author

Verification at head f934f7c2029a740b7f77d1d92a92b9bf6ceef4bd (base ee251a89).

Check Result
CI on this head 15 of 15 checks pass
Codex code review clean ("Didn't find any major issues", commit f934f7c202)
Codex security review clean ("No security issues were found", commit f934f7c202)
Independent read-only reviewer (claude-opus-5-5, xhigh) VERDICT #930 f934f7c2029a740b7f77d1d92a92b9bf6ceef4bd PASS; its two wording nits are applied to the body
Reviewer's binary comparison: go build -trimpath -buildvcs=false ./cmd/openstorage at base and head .text identical on linux/amd64 and linux/arm64; symbol tables with addresses identical on all four release platforms; only the module version strings differ
x/net vendor-diff check upstream v0.62.0..v0.63.0 is 2 commits (http2 fix for golang/go#83005, x/ dependency update); among the 8 vendored x/net packages only http2/transport_wrap.go changes; the binary has no x/net http2 Transport or ClientConn symbol
google.golang.org/api and genproto rpc vendored api packages byte-identical between versions; the two genproto rpc pseudo-versions have identical file trees
Local race lane, PostgreSQL: go test ./... -tags=openstorage_viewcheck -count=1 -race rc 0, 25 packages ok, 0 failures, 814 s
Local race lane, local backend: githttp rc 0, 908 s
Real-server smoke (local mode, osv.sh) 19 of 19 PASS
go mod verify, go build ./..., go vet with tests for linux and darwin on amd64 and arm64, golangci-lint 2.15.0, govulncheck 1.9.0 at main and head pass; 0 lint issues; no vulnerabilities

Lane environment: go1.27.4, git 2.55.0, git-lfs 3.8.1, host load 2 to 29.


Generated with xum • Model: anthropic:claude-opus-5-5 • Thinking: xhigh

@ThomasK33
ThomasK33 added this pull request to the merge queue Nov 20, 2026
Merged via the queue into main with commit bff9bc4 Nov 20, 2026
16 checks passed
@ThomasK33
ThomasK33 deleted the issue911-xnet-gapi branch November 20, 2026 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant