Repository navigation
fix: remove duplicate scrape_configs from prometheus.yml - #87
Merged
Merged
Conversation
dannykopping
marked this pull request as ready for review
October 6, 2026 13:13
dannykopping
force-pushed
the
fix/prometheus-duplicate-scrape-configs
branch
from
October 7, 2026 09:31
5fe67df to
6438c44
Compare
dannykopping
approved these changes
Oct 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two regressions introduced by #85's Prometheus upgrade in v0.7.4. v0.7.3 is unaffected.
serverFiles."prometheus.yml".scrape_configs: []setting. It duplicates the new chart'sscrape_configskey, causing Prometheus 3.13.2 to exit at startup. Chart-managed scraping remains disabled throughscrapeConfigs.--enable-feature=remote-write-receiverflag with--web.enable-remote-write-receiverso the collector can deliver metrics.CI coverage
Add Validate Prometheus config correctness: compile the configuration and alert rules, start the rendered Prometheus image with its rendered arguments, and require
/-/readyto succeed within a bounded retry window. Print server logs and clean up afterward.make test/prometheusdepends onbuild. The shell check runs in PR/main CI, nightly builds, and against the packaged chart before publication. It validates startup and configuration loading; Kubernetes discovery and metrics ingestion are outside its scope.Validation
field scrape_configs already set in type config.plain.make lintand ShellCheck pass locally.