Skip to content

fix: remove duplicate scrape_configs from prometheus.yml - #87

Merged
dannykopping merged 8 commits into
mainfrom
fix/prometheus-duplicate-scrape-configs
Oct 7, 2026
Merged

dannykopping merged 8 commits into
mainfrom
fix/prometheus-duplicate-scrape-configs

Conversation

@coder

@coder coder Bot commented Oct 6, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Fix two regressions introduced by #85's Prometheus upgrade in v0.7.4. v0.7.3 is unaffected.

  • Remove the legacy serverFiles."prometheus.yml".scrape_configs: [] setting. It duplicates the new chart's scrape_configs key, causing Prometheus 3.13.2 to exit at startup. Chart-managed scraping remains disabled through scrapeConfigs.
  • Replace the ignored --enable-feature=remote-write-receiver flag with --web.enable-remote-write-receiver so the collector can deliver metrics.
  • Regenerate the compiled manifests and README, and sync chart metadata to v0.7.4.

CI coverage

Add Validate Prometheus config correctness: compile the configuration and alert rules, start the rendered Prometheus image with its rendered arguments, and require /-/ready to succeed within a bounded retry window. Print server logs and clean up afterward.

make test/prometheus depends on build. The shell check runs in PR/main CI, nightly builds, and against the packaged chart before publication. It validates startup and configuration loading; Kubernetes discovery and metrics ingestion are outside its scope.

Validation

  • Ran the isolated CI command against v0.7.4 with only the test harness added: compilation passed, but readiness failed with field scrape_configs already set in type config.plain.
  • The fixed source chart and packaged chart pass the readiness check.
  • Separately verified that the receiver-flag fix permits writing and querying a metric.
  • make lint and ShellCheck pass locally.

@dannykopping
dannykopping marked this pull request as ready for review October 6, 2026 13:13
@dannykopping
dannykopping self-requested a review as a code owner October 6, 2026 13:13
@dannykopping
dannykopping force-pushed the fix/prometheus-duplicate-scrape-configs branch from 5fe67df to 6438c44 Compare October 7, 2026 09:31
@dannykopping
dannykopping merged commit 33cd6b0 into main Oct 7, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant