Repository navigation
ci: run release jobs in reviewed environments and tighten release.yaml - #193
Merged
Merged
Conversation
Collaborator
Author
|
@codex review |
deansheather
marked this pull request as ready for review
November 18, 2026 11:28
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
ThomasK33
approved these changes
Nov 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runs both jobs of
release.yamlin reviewed environments and tightens the workflow, so the repository-level secrets can move into those environments. Part of moving coder repositories off repository-level secrets.Depends on coder/github-org-terraform#134, which adds coder-desktop-release-managers as reviewers of
code-signing, limits it tov*tags, and creates thewingetenvironment. Merge this after that is applied. Otherwise GitHub createswingeton first use with no protection.Changes (
.github/workflows/release.yaml)v*tag pushes.workflow_dispatchand itsversioninput are removed, because they aren't needed: every Release run in the last year came from a tag push. The tag pattern was'*', but the version step already rejected anything that isn'tvX.Y.Z.permissions: {}.releasegetscontents: write(create the release) andid-token: write(workload identity for EV signing and the appcast upload).wingetgetscontents: read. It used to inherit both write permissions, but it usescdrci's token for everything outside this repository.wingetjob:environment: winget, soCDRCI_GITHUB_TOKENcan move there and only reaches this job after a release manager approves it.actions/checkoutv4.4.0,actions/setup-dotnetv4.3.1,actions/upload-artifactv4.6.2 andsoftprops/action-gh-releasev2.6.2 are pinned to commit SHAs.persist-credentials: falseon both checkouts.git fetch --tagsinwingetstill works because the repository is public.jsign-6.0.jaris checked against SHA-25605ca18d4…fa8abefore it signs anything. That is the same checksum coder/coder'sbuild-coderaction pins. I also computed it from the release asset myself.$env:GITHUB_REF_NAMEinstead of expanding${{ github.ref_name }}into the script.Secrets afterwards
The
secrets.NAMEreferences stay as they are. Environment secrets take precedence over repository secrets with the same name, so each value is copied into its environment first and the repository copy is deleted after a release works.code-signingGCP_WORKLOAD_ID_PROVIDER,GCP_SERVICE_ACCOUNT,EV_SIGNING_CERT,EV_KEYSTORE,EV_KEY,EV_TSA_URL,APPCAST_SIGNATURE_KEY_BASE64wingetCDRCI_GITHUB_TOKENAPPCAST_SIGNATURE_KEY_BASE64remains a stored key.Update-AppCast.ps1signs each installer, not only the small appcast, with raw Ed25519 (openssl pkeyutl -rawin). Ed25519 signs the whole message rather than a hash, so a KMS key would have to receive the entire installer in every signing request.Effect on releases
Pushing a
v*tag starts the release as before.releasewaits for an approval from a desktop release manager other than the person who pushed the tag, andwingetwaits for one more afterreleasefinishes.Checks
AI disclosure: an AI coding agent (Xum) wrote this change and ran the checks above at my direction. It stays a draft until I've reviewed it.