Repository navigation
Simulator: heavyweight menu popups so the canvas blit cannot smear them - #6104
Merged
Merged
Conversation
…em (#5850) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…hrome menus get them too Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Contributor
|
Developer Guide build artifacts are available for download from this workflow run:
Developer Guide quality checks: |
Collaborator
Author
|
Compared 12 screenshots: 12 matched. |
Contributor
✅ Continuous Quality ReportTest & Coverage
Static Analysis
Generated automatically by the PR CI workflow. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5850
The simulator canvas blits straight to the screen through
getGraphics(), outside Swing's paint cycle. Lightweight menu popups paint into the same surface, so wherever one overlaps the canvas/skin the next blit overwrites it and it smears. The old workaround repainted open menus after each blit, but translated them by the invoker's X only, which was wrong in landscape and when zoomed.installMenunow callsJPopupMenu.setDefaultLightWeightPopupEnabled(false), so popups get their own native window above the canvas.Not yet verified by eye on Windows 11 landscape.
🤖 Generated with Claude Code