Skip to content

fix(proxy): update PREFERRED_CLAUDE_MODELS to include claude-sonnet-5 - #535

Open
gokhanozdemir wants to merge 2 commits into
codemie-ai:mainfrom
gokhanozdemir:fix/473-pREFERRED_CLAUDE_MODELS
Open

fix(proxy): update PREFERRED_CLAUDE_MODELS to include claude-sonnet-5#535
gokhanozdemir wants to merge 2 commits into
codemie-ai:mainfrom
gokhanozdemir:fix/473-pREFERRED_CLAUDE_MODELS

Conversation

@gokhanozdemir

@gokhanozdemir gokhanozdemir commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Summary

Update the curated PREFERRED_CLAUDE_MODELS list in the desktop proxy connector so Claude Desktop gets the latest cloud lineup (Opus 5 / Sonnet 5 / Haiku 4.5), with older IDs kept only as gateway fallbacks.

Motivation

The desktop proxy connector's model list was outdated and did not include claude-sonnet-5. Exact-match preferred resolution meant Claude Desktop could lose Sonnet entirely when the gateway retired older Sonnet IDs.

Changes

  • Extended PREFERRED_CLAUDE_MODELS with claude-opus-5, claude-opus-3, and claude-sonnet-5 (kept prior Opus/Sonnet/Haiku entries as fallbacks)
  • Collapsed Sonnet the same way as Opus in selectDesktopClaudeModels, so Desktop shows at most one Opus and one Sonnet (latest available)
  • Expanded desktop connector tests to assert Opus 5 / Sonnet 5 selection, fallbacks, and sonnet collapse — not just preferred-list order
  • Hardened migration-runner-ordering Windows teardown (rmSync retries + best-effort catch) to fix the unrelated ENOTEMPTY CI flake

Testing

  • Focused desktop + migration suites pass (114 tests in those files)
  • Pre-commit eslint / related vitest / typecheck passed on commit

Breaking Changes

None — Desktop still exposes one Opus + one Sonnet + Haiku; only the preferred IDs and collapse rules track the current generation.

Related Issues

Fixes #473

Screenshot from Claude Desktop as of 05 Sep 2026

image

@gokhanozdemir
gokhanozdemir force-pushed the fix/473-pREFERRED_CLAUDE_MODELS branch from a0f8b0b to 9966948 Compare September 5, 2026 15:58
@gokhanozdemir
gokhanozdemir marked this pull request as ready for review September 5, 2026 16:36
@gokhanozdemir
gokhanozdemir force-pushed the fix/473-pREFERRED_CLAUDE_MODELS branch from 42b9bdd to 784690c Compare September 5, 2026 17:44
Comment thread src/cli/commands/proxy/connectors/desktop.ts Outdated
@gokhanozdemir
gokhanozdemir force-pushed the fix/473-pREFERRED_CLAUDE_MODELS branch 2 times, most recently from acd4199 to 09cc4bd Compare September 8, 2026 17:28
@gokhanozdemir
gokhanozdemir marked this pull request as draft September 9, 2026 21:01
@gokhanozdemir
gokhanozdemir force-pushed the fix/473-pREFERRED_CLAUDE_MODELS branch 2 times, most recently from 12a1c61 to d307f8d Compare September 9, 2026 22:20
@gokhanozdemir

Copy link
Copy Markdown
Contributor Author

@8nevil8 could you please take a look? https://github.com/codemie-ai/codemie-code/actions/runs/34411740542/job/102667849670#step:7:225 do you have any suggestions here why those tests be failing?

@gokhanozdemir
gokhanozdemir force-pushed the fix/473-pREFERRED_CLAUDE_MODELS branch from d307f8d to 3f322d8 Compare September 9, 2026 23:11
@gokhanozdemir
gokhanozdemir force-pushed the fix/473-pREFERRED_CLAUDE_MODELS branch from 3f322d8 to bae3c32 Compare September 10, 2026 00:33
@gokhanozdemir
gokhanozdemir marked this pull request as ready for review September 10, 2026 00:38
@gokhanozdemir

Copy link
Copy Markdown
Contributor Author

@8nevil8 could you please take a look? https://github.com/codemie-ai/codemie-code/actions/runs/34411740542/job/102667849670#step:7:225 do you have any suggestions here why those tests be failing?

ok resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PREFERRED_CLAUDE_MODELS in desktop proxy connector is outdated — missing claude-sonnet-5

2 participants