Repository navigation
Page builder fixes: pricing period switch, header GitHub link, block icons (#137) - #138
Merged
Merged
Conversation
…icons Fixes the page builder issues grouped under #137: - Pricing (#134): one desktop column per plan (up to 4), so 1-2 plans fill the row; a single plan is capped at max-w-xl. Optional Monthly/Yearly switch with per-tier priceYearly and buttonActionYearly that fall back to the monthly values. Both prices are server-rendered and a small client island flips between them. - Header (#132): hide the mobile menu button when there are no links or CTA. - Header (#133): optional GitHub link (githubRepo, owner/repo or a github.com URL) with an optional star count fetched in the browser. - Every built-in block has its own icon in the block picker and the settings panel header. Closes #132, closes #133, closes #134.
Also pass --no-errors-on-unmatched to biome in the pre-commit hook, so commits that only touch files biome ignores (e.g. Markdown) don't fail.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the page builder issues grouped under #137.
Pricing (#134)
max-w-xl.pricingSwitcher,monthlyPriceCaption,yearlyPriceCaption,defaultPeriod(defaults to yearly, like CourseLit). Each tier getspriceYearlyandbuttonActionYearly, which fall back toprice/buttonAction.pricing-period-switch) setsdata-periodand CSS shows the matching price and button.Header (#132, #133)
githubRepo(owner/repoor a github.com URL) andshowGithubStars. The star count is fetched in the browser (islandheader-github-stars) so it doesn't use the server's GitHub API quota, and is hidden on error or 0. The field is a plain string; the header ignores values that don't parse as a repo, so clearing or half-typing it still autosaves.Block icons
Every built-in block sets
metadata.icon, so the "Add a block" picker and the block settings header show a distinct icon per block instead of one shared layout icon.Schema
Zod schemas updated;
schema/page.v1.jsonandschema/site.v1.jsonregenerated. Changeset included.Testing
githubRepo); every block having a distinct, valid icon.bun run typecheckandbun run testpass across the workspace.Not in this PR
frontlit-skills(frontlit-pages/references/blocks.md).Closes #132, closes #133, closes #134.