Repository navigation
fix(release): build packages in dependency order before publishing - #130
Merged
Merged
Conversation
changeset publish ran each package's prepublishOnly build in parallel. text-editor's build cleans dist/ while page-builder's type build reads @frontlit/text-editor/renderer from it, so page-builder@0.1.0-alpha.4 failed to publish and preview@0.1.0-alpha.2 now depends on a version that doesn't exist. The release script now builds text-editor and media-uploader, then page-builder, before publishing, and the parallel prepublishOnly builds are removed. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The publish run for #55 failed for
@frontlit/page-builder@0.1.0-alpha.4:changeset publishruns every package'sprepublishOnlybuild in parallel. text-editor's build cleansdist/while page-builder's type build reads@frontlit/text-editor/rendererfrom it. The other three packages published, so@frontlit/preview@0.1.0-alpha.2now depends onpage-builder@0.1.0-alpha.4, which isn't on npm.npx @frontlit/preview@alphacurrently fails withETARGET.Change
releasebuilds text-editor and media-uploader, then page-builder, then publishes.prepublishOnlyfrom the three packages so publish doesn't rebuild them in parallel again.Testing
From a clean state (all three
dist/removed), the new build steps succeed.npm pack --dry-runfor page-builder0.1.0-alpha.4gives 141 files, the same as the published0.1.0-alpha.3.After merge
This PR doesn't touch
.changeset/, so the publish workflow won't run on its own. Run it withworkflow_dispatch. With no pending changesets, it publishes only the missingpage-builder@0.1.0-alpha.4.🤖 Generated with Claude Code