Repository navigation
Deny the non-icon files of webicons/, name the copyright holder of webicons/LICENSE - #111
Merged
Merged
Conversation
…older of webicons/LICENSE README, check.js and the preview page of webicons/ are not used by the wiki: Apache (.htaccess) and the nginx rules (INSTALL.md, tests/Server/nginx/w2.conf.template) deny them, and ServerConfigTest checks it. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AFJFMPsCLSiYLjcJ1agpYs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
webicons/README.md,check.jsand the preview page (preview.html,.css,.js) are not used by the wiki, so they are denied:.htaccess(RedirectMatch 404 /webicons/(?!icons/)), the nginx rules inINSTALL.mdand the copy intests/Server/nginx/w2.conf.template.tests/Server/ServerConfigTest.phpchecks that these files are not served (the icons still are).webicons/LICENSEnames the holder (Bernhard Froehler) instead of "the webicons contributors".Not run here:
tests/Server/run.sh(needs Docker or Podman).webicons/is a subtree: theLICENSEchange needs the same commit incodeling/webicons, or the nextgit subtree pullbrings the old text back.Generated by Claude Code