Repository navigation
deploy.sh: take the version from the manifest - #27
Merged
Merged
Conversation
The version was written in deploy.sh as well, and had to be raised there for every release. Plugin, component and package are built together by package/build.sh in codeling/bfstop now, which checks that their versions agree (tests/lint/check-versions.php). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AFJFMMUpch4LGexEiXN8Nc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of moving the package build into codeling/bfstop. Merge together with the bfstop PR on the branch of the same name.
deploy.shhad the version written into it as well, so it had to be bumped by hand for every release. It now reads the version frombfstop.xml. bfstop'spackage/build.shbuilds the component with this script and checks that its version matches the plugin's and the package's.With the bfstop PR, this repository's CI installs the component as part of the package built from both checkouts (
install-joomla.sh); nothing changes in this workflow.Tested:
./deploy.sh zipstill producescom_bfstop-2.0.0.zip, andcheck-zippasses. bfstop's full suite passes locally with a package built from this branch.Generated by Claude Code