chore: drop the design-JSP mappings from the systemHelper override - #18
Merged
Merged
Conversation
Fess 15.9 removes the JSP search pages and the per-virtual-host JSP copies, so fess.xml no longer registers design JSP names on systemHelper and SystemHelper.addDesignJspFileName() is gone. The override repeated those 19 calls, which now name a method that does not exist: initializing the component fails with BeanMethodNotFoundException, as the plugin's own tests show. The override now declares no postConstruct, like the core definition. The README and the CustomSystemHelper javadoc say what to keep in step with, and the requirement moves to Fess 15.9.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fess 15.9 removes the JSP search pages and the per-virtual-host JSP copies, and with them
SystemHelper.addDesignJspFileName(). ThesystemHelperoverride repeated the 19addDesignJspFileNamecalls fromfess.xml; on 15.9 they name a method that no longer exists, so initializing the override fails withBeanMethodNotFoundException. The override now declares nopostConstruct, like the core definition, and the README requirement moves to Fess 15.9.This can merge before the Fess change: on a Fess that still has the method, the override simply registers no design JSP names.
Verification
mvn testagainst a Fess 15.9 build without the method: all tests pass; with the old override,CustomSystemHelperTestfails withBeanMethodNotFoundException.systemHelpertoCustomSystemHelper.