docs(15.9): api.access.token.required was removed - #557
Merged
Merged
Conversation
Fess 15.9 no longer has api.access.token.required. Regenerate the 15.9 properties pages and drop the key's description from the translation catalogues, and add a section to the 15.9 upgrade notes in all seven languages: a value left under the key has no effect, anonymous API requests are now answered with the guest roles, login.required=true is the way to keep anonymous users from searching, and access tokens work as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Document the removal of
api.access.token.requiredin Fess 15.9.The setting refused API requests from users who were not logged in. In 15.9 the default search UI is a static theme that searches through
/api/v2/search, so the setting only left anonymous users with an empty search page, and it was removed from Fess.Changes
*/15.9/config/properties.rst: regenerated withtools/update_properties_doc.sh; theapi.access.token.requiredrow is gone.*/15.9/config/properties.po: the key's description is dropped from the catalogues.*/15.9/install/upgrade.rst(7 languages): new section "api.access.token.requiredWas Removed" in the 15.8 to 15.9 part. It says that a value left under the key has no effect, that anonymous API requests are now answered with the guest roles, thatlogin.required=truekeeps anonymous users from searching, and that access tokens still add their permissions (an unregistered or expired token is still refused).Only the rows for this key were taken from the regeneration; other differences between the generated pages and the current
fess_config.propertiesare left for a separate update.Checks
python3 tools/gen_properties_doc.py --check: the 7 properties pages agreepython3 tools/check_headings.py */15.9/install/upgrade.rst: no mismatchesupgrade.rstfiles: no new errors or warningsDependency
This describes codelibs/fess#3496, which removes
api.access.token.required. Merge it together with, or after, that PR.