Repository navigation
fix: sort AbstractGeneratorCommand imports in templates with CRLF line endings - #10623
Merged
paulbalandan merged 1 commit intoOct 13, 2026
Merged
Conversation
carson-codeigniter4
Bot
added
4.8
michalsn
approved these changes
Oct 12, 2026
paulbalandan
force-pushed
the
crlf-import-sorting-48
branch
from
October 13, 2026 05:44
b4ef0d8 to
c59d02c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up to #10622 for
AbstractGeneratorCommandon4.8. ItsbuildContent()finds the import block with the same/(?:^use [^;]+;$\n?)+/mpattern asGeneratorTrait. On a template with CRLF line endings, the\rafter each;breaks the match and the imports are left unsorted.Checklist: