Repository navigation
Report an unlistable directory as IOException instead of NullPointerException - #349
Merged
Merged
Conversation
…re and cleanDirectoryOnExit File.listFiles() returns null when a directory cannot be read; both methods dereferenced it and failed with a NullPointerException that named nothing. cleanDirectory already checks for null.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
File.listFiles()returns null for a directory that exists but cannot be read.copyDirectoryStructureandcleanDirectoryOnExitdereferenced it and failed with aNullPointerExceptionthat named nothing; they now throw anIOExceptionwith the directory path, ascleanDirectoryalready did by returning. Found while replacing another copy of this utility, which skipped such a directory silently, with this one.Verified:
mvn verify→ all tests pass; the new test skips where the directory stays readable (root, Windows).