V10.7.0/razor enhancement and service update - #169
Conversation
Enable central package transitive pinning for better dependency resolution across the monorepo. Add Newtonsoft.Json as a conditional package dependency for Cuemon.Core.Tests to support test scenarios.
Document version 10.7.0 release with notes about dependency upgrades to latest compatible versions across all supported target frameworks (.NET 10, .NET 9, and .NET Standard 2.0).
Greptile SummaryThe PR adds automatic request-based URL resolution for Razor tag helpers, updates package dependencies and release notes for version 10.7.0, and adds the missing public API documentation requested in the previous review.
Confidence Score: 5/5The PR appears safe to merge. No blocking failure remains. Important Files Changed
Reviews (4): Last reviewed commit: "✅ refactor awaiter timeout tests to use ..." | Re-trigger Greptile |
| /// Specifies how the base URL of a static resource is resolved. | ||
| /// </summary> | ||
| public enum TagHelperBaseUrlMode | ||
| { |
There was a problem hiding this comment.
TagHelperBaseUrlMode is a new public type, but this change does not add the required per-type DocFX overwrite with a realistic usage example. As a result, the generated API documentation does not show consumers how to configure automatic URL resolution.
Context Used: AGENTS.md (source)
Prompt To Fix With AI
This is a comment left during a code review.
Path: src/Cuemon.AspNetCore.Razor.TagHelpers/TagHelperBaseUrlMode.cs
Line: 6
Comment:
**Document the new public API**
`TagHelperBaseUrlMode` is a new public type, but this change does not add the required per-type DocFX overwrite with a realistic usage example. As a result, the generated API documentation does not show consumers how to configure automatic URL resolution.
**Context Used:** AGENTS.md ([source](https://github.com/codebeltnet/cuemon/blob/main/AGENTS.md))
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #169 +/- ##
=======================================
Coverage 94.22% 94.23%
=======================================
Files 604 604
Lines 19688 19707 +19
Branches 2104 2103 -1
=======================================
+ Hits 18552 18570 +18
- Misses 1072 1073 +1
Partials 64 64 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This pull request updates the release notes for multiple NuGet packages in the Cuemon library to announce version 10.7.0. The primary focus is on upgrading dependencies to their latest compatible versions across all supported target frameworks. Additionally, the
Cuemon.AspNetCore.Razor.TagHelperspackage introduces several new features and enhancements related to tag helper URL resolution.Dependency Upgrades
New Features and Enhancements in Razor Tag Helpers
TagHelperBaseUrlModeenum to control how base URLs are resolved in tag helper options.CacheBustingTagHelpervia the newResolveUrlmethod.ViewContextproperty toCacheBustingTagHelperfor access to the current HTTP request context.ImageTagHelper,LinkTagHelper, andScriptTagHelperto support automatic URL resolution from the current HTTP request whenTagHelperBaseUrlMode.Automaticis configured.