Skip to content

Embed email stylesheet directly in mailer header #2724

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mroderick wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Embed email stylesheet directly in mailer header #2724

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions app/assets/images/email/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ the mailer view to reference the new file. Never mutate an existing file.

## Email stylesheet

The email CSS lives at `app/assets/stylesheets/email.css` — not in this
folder — but it's referenced by mailer layouts via the pipeline path
`email.css`.
The email CSS is embedded directly in the email `<head>` via
`app/views/shared_mailers/_header.html.haml`. It is no longer loaded from the
asset pipeline, so there is no external stylesheet URL to go stale or change
after an email is sent.
226 changes: 0 additions & 226 deletions app/assets/stylesheets/email.css
View file
Open in desktop

This file was deleted.

Loading