Skip to content

fix(js): use Bootstrap 5 vanilla API for tooltips #2723

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mroderick wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −4
Open

fix(js): use Bootstrap 5 vanilla API for tooltips #2723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion app/assets/javascripts/application.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,5 +152,7 @@ $(function() {
no_results_text: 'No results matched'
});

$('[data-bs-toggle="tooltip"]').tooltip();
document.querySelectorAll('[data-bs-toggle="tooltip"]').forEach((el) => {
new bootstrap.Tooltip(el);
});
});
6 changes: 3 additions & 3 deletions spec/features/admin/meeting_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@
click_on 'Save'

expect(page).to have_content('You have successfully updated the details of this meeting')
expect(page).to have_css(%(span[title="#{permissions.members.last.full_name}"]))
expect(page).not_to have_css(%(span[title="#{permissions.members.first.full_name}"]))
expect(page).to have_css(%(img[alt="#{permissions.members.last.full_name}"]))
expect(page).not_to have_css(%(img[alt="#{permissions.members.first.full_name}"]))
end

scenario 'adding an organiser', :js do
Expand All @@ -71,7 +71,7 @@

click_on 'Save'

expect(page).to have_css(%(span[title="#{new_organiser.full_name}"]))
expect(page).to have_css(%(img[alt="#{new_organiser.full_name}"]))
end
end

Expand Down