feat(sync): sync the contract from a local checkout - #3
Merged
Conversation
Trying a contract change meant pushing it to ocp-protobuf-api first, because sync-protos.sh only ever cloned. `--local <path>` reads a checkout's working tree instead, so an uncommitted .proto edit reaches codegen, and the apps, with nothing pushed. The mode is deliberately hard to merge. It writes `commit: LOCAL` to ocp.lock, and both CI and the publish workflow fail while it says that, so proto/ cannot reach main or Maven Central without an upstream commit behind it.
This was referenced Aug 25, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trying a one-field contract change meant pushing to
ocp-protobuf-api, cutting a release here, andbumping both apps. Maven Central will not take a version number twice, so every throwaway iteration
burned a real version.
scripts/sync-protos.sh --local [path]reads a checkout's working tree instead of cloning at thepinned SHA, uncommitted edits included. The path defaults to
$OCP_UPSTREAM_PATH, then to../ocp-protobuf-api. Everything downstream ofproto/is unchanged: the same re-namespacing andthe same generators run.
The lock file is what keeps a local sync from shipping.
--localwritescommit: LOCALintoocp.lock, along with the local HEAD and whether that working tree was dirty. A newcontractjobin
ci.ymlfails on it andpublish.ymlrefuses to release it, soproto/cannot reachmainorMaven Central without an upstream commit behind it. Re-running the sync with no argument against a
LOCALlock is an error too, rather than a confusinggit checkout LOCALfailure.The app side of the loop lands separately: code-payments/code-android-app#1327 and
code-payments/code-ios-app#646.