feat(wallet): show a grabbed deposit landing in the wallet - #697
Open
bmc08gt wants to merge 1 commit into
Open
Conversation
"Put in Wallet" dismissed the bill and left the user on the Scan tab, with nothing to show that the money had arrived. The grab refreshes `Session.balances` while the bill is still on screen, so by then the balance had already risen out of sight. The button now routes to the wallet, and `WalletDeposit` carries the pre-deposit total and card set across. On arrival the wallet rewinds to those figures in one un-animated frame, still under the outgoing bill, waits for the bill and its sheet to clear, then sets the real ones: the balance header rolls its digits, and a token the wallet had no card for rises into the deck. The baseline is held on the session rather than in the view because the wallet may not exist yet — the pre-iOS 26 tab path builds it when the tab is selected, which is the moment "Put in Wallet" asks for. While a deposit is pending, `refresh()` is held off the figures the animation is moving; it runs once more after, to pick up anything that shifted.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Grabbing a cash bill and tapping Put in Wallet dismissed the bill and left the user on the Scan tab. Nothing showed that the money had arrived: the grab refreshes
Session.balanceswhile the bill is still on screen, so the balance had already risen out of sight.The button now routes to the wallet, and a new
WalletDepositcarries the pre-deposit total and card set across the dismissal. On arrival the wallet rewinds to those figures in one un-animated frame — still under the outgoing bill — waits for the bill and its sheet to clear, then sets the real ones. The balance header rolls its digits on its existing.numericText()transition, and a token the wallet had no card for rises into the deck.Two things that are not obvious from the diff:
WalletScreenContent.initseeds from the pending landing.refresh()is held off the balance figures — refreshing mid-flight would put the total straight to the value the animation is on its way to. It runs once more after the animation completes, to pick up anything that shifted meanwhile.The arriving card keeps its slot in
cardsfor the whole animation and only its own offset and opacity move, so the deck does not jump a frame as indices shift.New tests cover
WalletDeposit's arm/release/discard/consume transitions and theSession.walletCardBalancesfilter, plusAppRouter.showWallet()routing: selects the balance tab at root, clears sheets, closes an expanded card, and does not refire while a request is in flight.