feat(myaccount): make User Profile show the identity instead of editing it - #1351
Merged
Conversation
It sat last, below the settings that edit it. Leading with it puts the account
being described before the rows that change it.
Order comes from FullMenuList, and the existing assertions use any {}, so the
reorder was invisible to the tests. Adds one that pins the full order.
User Profile needs the same link formatting the You tab uses, but it can't reach the helper: myaccount depends on :apps:flipcash:shared:menu, not :apps:flipcash:features:menu. Both feature modules get :apps:flipcash:core from the convention plugin, so the helper moves there and becomes public. One implementation means the two screens can't drift on how a link reads.
The screen carried its own edit entry points for the display name and the photo, so two places answered "where do I change this?" Both routes pushed AppRoute.UpdateUserProfile — the same destination My Account already offers one level up. The header is now read only and My Account is the single answer. What the header gains is the public identity it was missing: @handle and the flipcash.com link, tap to copy. The link row is the You tab's row, down to the copy glyph holding a checkmark for 1.5s after the tap, because the clipboard gives no feedback of its own. With no handle claimed it states the minimum balance instead, read from userFlags.resolvedFlags.usernameMinBalance — the same flag the claim screen's rejection dialog quotes, so the two can't name different thresholds. Stated rather than actionable: claiming happens on the You tab. The taller header also made the list exactly one screen tall, which left it unable to scroll and put the last card under the gesture bar. Bottom contentPadding plus navigationBarsPadding fixes both.
navigationBarsPadding sat on the list itself, so the gesture-bar inset shortened the viewport and cut the last card off at the padded edge. The inset moves into contentPadding: the list fills the window again and the last card scrolls clear of the bar. The edges now fade with verticalScrollStateGradient, at the top and the bottom, so content reads as running past the app bar and the gesture bar rather than stopping at them. The bar title goes too. The header names the account directly below it, so a title said the same thing twice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User Profile (staff/beta) carried its own edit entry points for the display name
and the photo. Both pushed
AppRoute.UpdateUserProfile— the destination MyAccount already offers one level up, so two screens answered the same "where do
I change this?" and neither was obviously the right one.
The edit routes are gone. My Account is now the single place profile fields are
changed, and User Profile describes the account.
What the header gains is the public identity it was missing:
@handleand theflipcash.comlink, tap to copy. The row is the You tab's row down to the copyglyph holding a checkmark for 1.5s, because the clipboard gives no feedback of
its own. Sharing that row meant
abbreviatedLink()had to move —myaccountdepends on
:apps:flipcash:shared:menu, not:apps:flipcash:features:menu, soit now lives in
:apps:flipcash:corewhere both feature modules can reach it.One implementation means the two screens can't drift on how a link reads.
With no handle claimed the header states the minimum balance instead, read from
userFlags.resolvedFlags.usernameMinBalance— the same flag the claim screen'srejection dialog quotes, so the two can't name different thresholds. It's stated,
not actionable: claiming happens on the You tab.
Two smaller fixes came out of running it on device. The taller header made the
list exactly one screen tall, which left it unable to scroll at all and put the
last card under the gesture bar; bottom
contentPaddingplusnavigationBarsPaddingfixes both. And User Profile moves to the top of the MyAccount list, so the account being described comes before the settings that
change it.