feat(myaccount): add a Profile Picture row, name the rows after what they edit - #1349
Merged
Conversation
… edit Node 9544:18478 lists the account's editable fields, and the photo had no row: it was only reachable through the staff/beta profile editor. The new row pushes the same single-step UpdateUserProfile flow that editor already uses, asking for the photo step alone. The labels drop their verb — "Change Display Name" becomes "Display Name", "Change Username" becomes "Username" — so the list reads as an inventory of the profile rather than a list of actions. Minimum Tip, also in that design, is left out of this change.
Material Symbols Outlined at 24dp/wght 400, converted from Google's -960 viewBox into the 0..960 one ic_biometrics already uses. Rendering the converted path back to SVG matches Google's original pixel for pixel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Node 9544:18478 reorganizes My Account. This lands two of its three changes.
A Profile Picture row. The photo had no row of its own — the only way to it was the staff/beta User Profile editor. The new row pushes the same single-step
UpdateUserProfileflow that editor already uses, asking for the photo step alone. Its icon is Material Symbols Outlinedfamiliar_face_and_zone, converted from Google's-960viewBox into the0..960oneic_biometricsalready uses; rendering the converted path back to SVG matches Google's original pixel for pixel.The labels drop their verb. "Change Display Name" becomes "Display Name" and "Change Username" becomes "Username", per the note on the frame, so the list reads as an inventory of the profile rather than a list of actions. The two string keys were renamed to match — nothing else referenced them.
Row order follows the flow's own step order (name, username, photo), so a claimed handle sits between the two. Username stays conditional on a claimed handle and Profile Picture carries no condition.
Minimum Tip, the design's third change, is out of scope here: #1344 scaffolded
SetMinDmChatInitFee, and wiring the row to it is its own piece of work.