feat(navbar): fill each tab's glyph only while it is selected - #1348
Merged
Conversation
The wallet and tip card were drawn as fills and the scanner and chat as outlines, so the weight of a glyph said nothing about which tab was active -- selection was carried by the pill and a half-alpha dim alone. Every tab now ships both weights and switches on selection, matching nodes 9442:103674 (wallet outline) and 8966:1366 / 8966:99595 / 8966:2774 (the solid twins). The unsuffixed drawable is the outline, so `ic_nav_scan` keeps pointing at the weight the Finish Your Profile card reuses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The tab bar mixed weights: the wallet and tip card were fills, the scanner and chat outlines. Nothing about a glyph told you which tab was active — selection was carried entirely by the pill behind it and a half-alpha dim on the other three.
Every tab now has both weights and picks one from its selection state:
ic_nav_scanic_nav_scan_selected(node 8966:1366)ic_nav_wallet(node 9442:103674)ic_nav_wallet_selectedic_nav_chatic_nav_chat_selected(node 8966:99595)ic_nav_tipcardic_nav_tipcard_selected(node 8966:2774)The unsuffixed name is the outline throughout, which is why the wallet's existing fill moved to
ic_nav_wallet_selectedrather than the new outline taking a suffix:ic_nav_scankeeps pointing at the weight the Finish Your Profile card reuses, and the naming reads the same for all four tabs.NavBarButton.iconbecomesicon(selected: Boolean). The alpha dim is unchanged and still stacks on top.Touches the same lines of
NavigationBar.ktas #1347, which wraps thatImagein a branch for the profile avatar — whichever merges second will need a small conflict resolution there.