test(tokens): supply accountController to SwapViewModel - #1345
Merged
Conversation
#1341 added a required `accountController` parameter to `SwapViewModel` and changed only `SwapViewModel.kt`, so `SwapViewModelErrorTest.createViewModel()` still calls the old constructor. The module's unit tests have not compiled since it merged, which fails every PR built against `code/cash`. Add the mock in constructor order and stub `observeHasAccountFor` to return false. Nothing in this file exercises the first-buy/top-up branch it feeds, and an explicit answer is steadier than a relaxed mock's empty flow. `SwapViewModelStateTest` never constructs the view model, so it needs nothing.
github-actions
Bot
added
type: test
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
code/cashdoes not compile its:apps:flipcash:shared:tokensunit tests. #1341 added a requiredaccountControllerparameter toSwapViewModeland changed onlySwapViewModel.kt, leavingSwapViewModelErrorTest.createViewModel()on the old constructor:Every branch cut from
code/cashinherits the break, because PR CI builds the merge commit rather than the branch head. #1344 is where I hit it.The fix is the mock and the argument.
observeHasAccountForis stubbed to return false: nothing in this file exercises the first-buy/top-up branch it feeds, and an explicit answer is steadier than a relaxed mock's empty flow.SwapViewModelStateTestonly uses the companion object, so it compiles either way and is untouched.:apps:flipcash:shared:tokens:testDebugUnitTestruns 35 tests across both classes with no failures.