chore(discovery): say "members" instead of "people" - #1329
Merged
Conversation
The leaderboard subtitle and the leaderboard info prompt both described token holders as people. Switch both to "members". `subtitle_personCount` is only referenced from the Discovery leaderboard rows, so it is renamed to `subtitle_memberCount` rather than left with a stale key. The internal `holder` naming (`HolderMetrics`, `RankingSystem.Holders`) is unchanged — it is not user-facing and mirrors the backend model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The leaderboard subtitle and the leaderboard info prompt both described token holders as people. Both now say "members".
subtitle_personCount→subtitle_memberCount("0 members" / "1 member" / "%1$s members"). The plural is only referenced from the Discovery leaderboard rows, so the key is renamed rather than left stale.prompt_description_learnAboutLeaderboard→ "Members must have a minimum balance of %1$s to be counted".Internal
holdernaming (HolderMetrics,currentHolders,RankingSystem.Holders,minimumHolderAmount) is unchanged — none of it is user-facing, and it mirrors the backend model. The remaining "people" strings in the app (contacts permission rationale, blocklist empty state, tip chat header) are outside Discovery and untouched.