fix(userflags): add the new flag to the ResolvedUserFlags fixture - #1324
Merged
Conversation
`usernameMinBalance` landed on UserFlags in #1322 without a default, so the test fixture no longer compiles and every PR against code/cash fails: ResolvedUserFlagsTest.kt:140:5 No value passed for parameter 'usernameMinBalance' The flag resolves with FieldOverride.None, so it needs no OverrideCase — only the fixture value and the assertion the first test's name already promises.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
usernameMinBalancelanded onUserFlagsin #1322 without a default, soResolvedUserFlagsTest's fixture no longer compiles.code/cashis red, and with it every open PR:The flag resolves with
FieldOverride.None, so it isn't overridable and needs noOverrideCase— the completeness guard coversOverridesfields, notUserFlagsfields. That leaves the fixture value and the assertion thatresolve without overrides exposes the server value for every flagalready promises by name.