Pegasus sweep 6/6: remove pegasus entries from chef crontab and VPC template - #74758
Open
stephenliang wants to merge 1 commit into
Open
Pegasus sweep 6/6: remove pegasus entries from chef crontab and VPC template#74758stephenliang wants to merge 1 commit into
stephenliang wants to merge 1 commit into
Conversation
stephenliang
changed the title
stephenliang
marked this pull request as ready for review
August 20, 2026 16:44
stephenliang
added a commit
that referenced
this pull request
Aug 20, 2026
All 31 tasks are done and shipped as a six-PR stack on staging (#74753-#74758, stack #74759; supersedes draft #74751). The implementation notes record the scope extensions found during verification: two k8s suppliers of pegasus_honeybadger_api_key, the dockerignore generated from aws/.gitignore, one co-deleted orphan, and the finding that the whole ServerTools class is dead. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
stephenliang
force-pushed
the
stephen/pegasus-sweep-6-deploy
branch
from
August 20, 2026 21:01
5ee2d79 to
5dea144
Compare
stephenliang
force-pushed
the
stephen/pegasus-sweep-6-deploy
branch
from
August 21, 2026 16:29
5dea144 to
a379158
Compare
…C template Two files with a deploy surface still reference pegasus. cookbooks/cdo-apps/templates/default/crontab.erb defines a pegasus_dir helper that no cron entry in the template calls. Delete the definition. The template renders on chef converge; a local render under seven node/env combinations produces identical cron entries with no pegasus reference. aws/cloudformation/vpc.yml.erb carries three "Pegasus Puma" ingress/egress rules for port 9001. Nothing listens on 9001; no nginx or puma config binds it, and pegasus_port has no configured value. Delete the three rules. This edit is inert until the next VPC stack update; the rendered template still parses, and all three security groups keep their remaining rules (ports 22, 80, 443, 9000). Part 6/6 of the pegasus dead-code sweep (openspec change pegasus-dead-code-sweep, plan in #73702). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
stephenliang
force-pushed
the
stephen/pegasus-sweep-6-deploy
branch
from
August 21, 2026 17:08
a379158 to
6f6a02c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two files with a real deploy surface still reference pegasus. This PR is the smallest slice of the sweep on purpose: ~20 lines, isolated so an infra reviewer can look at exactly this and nothing else.
cookbooks/cdo-apps/templates/default/crontab.erbdefines apegasus_dirhelper that no cron entry in the template body calls; every entry usesdeploy_dirordashboard_dir. The helper is template-local, so no other recipe can reach it. This PR deletes the definition.aws/cloudformation/vpc.yml.erbcarries three "Pegasus Puma" ingress/egress rules for port 9001 (ALB egress, legacy ELB egress, frontend ingress). Nothing listens on 9001: no nginx or puma config binds it,pegasus_porthas no configured value in any environment, and the pegasus systemd unit is torn down by chef. This PR deletes the three rules.Part 6/6 of the pegasus dead-code sweep. Supersedes draft #74751.
Links
pegasus-dead-code-sweep)Testing story
crontab.erb: rendered locally under seven node/env combinations (staging, staging-frontend, test, levelbuilder, production-daemon, production-frontend, adhoc); output contains no pegasus reference, and callingpegasus_dirafter evaluating the template raisesNoMethodError, which proves the helper is gone and unused.vpc.yml.erb: rendered through the repo's real renderer (Cdo::CloudFormation::StackTemplate, the same constructionlib/rake/stack.rakeuses) and YAML-parsed; all three security groups keep their remaining rules (ports 22, 80, 443, 9000) and noFromPort/ToPortof 9001 remains anywhere in the 55 rendered resources.Deployment notes
The chef template change takes effect on the next converge; rendered cron entries are identical. The security-group change is inert until the next VPC stack update — no separate deploy step here, but the next
stackapply will show three rule removals in its change set. Nothing binds port 9001, so removing the rules cannot cut off live traffic.