Repository navigation
feat: multi-select picker, and builds that lock, write atomically and clean up - #23
Merged
Merged
Conversation
A select with multiple() was the browser's <select multiple>: one item per click, and a saved selection could never be cleared because an empty selection submits nothing. It now renders real checkboxes (a chip picker with search above six options) and always sends an empty marker. The picker is plain JavaScript over the checkboxes, so keyboard use and the stored value are unchanged. display() chooses checkboxes, tokens or native. See ADR-0027. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
One build per project runs at a time (OS file lock; waitForLock() or --wait to queue). Zips and directories are written beside their target and moved into place, so a failed or stopped build leaves the previous output whole. Ctrl+C stops the running command and what it started and removes staging; abandoned staging is swept. Steps end with their duration, and an interactive terminal gets a spinner that never reaches logs. The runner polls a file the shell redirects into, because a descriptor handed to proc_open lost output in long test runs. See ADR-0026. Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two groups of changes for rc.8.
1. Multiple-choice fields (ADR-0027)
A
selectwith->multiple()was the browser's<select multiple>: one item per click, and a saved selection could never be cleared (an empty selection submits nothing, so the save treated the field as "not on this form"). It now renders real checkboxes: a plain list up to six options, a searchable chip picker above that.->display('checkboxes' | 'tokens' | 'native')overrides.2. Builds are safe to run twice and to stop (ADR-0026)
waitForLock()/--wait=N.CI,NO_COLOR,TERM=dumb,quiet(),plain()/--plainorwithOutput()applies.proc_openlost the child's output after certain earlier tests in the same PHP process; the cause was not identified, and this form does not depend on it.Verification
Not verified
Noticed, not changed: the
mediafield rendersdata-wptoolkit-mediafor an admin script that does not exist, so its button does nothing.🤖 Generated with Claude Code