Repository navigation
docs: fixture coverage, e2e usage and the proxy port doc say what the code does - #537
Merged
Merged
Conversation
… code does Python round-trips the corpus's request frames and only decodes each response to its type; the README, sdk-python.md and the test docstring said it round-trips the whole corpus. The three e2e usage lines named an rt2:24.04 template no image build produces. The silkd LOOPBACK_PORT doc named proxy.internal, which only a test uses as a placeholder host.
… Rust parses requests, Python decodes responses
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are doc and comment drifts I found while reading the repo file by file. There is no code change.
sdk/python/README.md,docs/sdk-python.mdand thetest_fixtures.pymodule docstring said Python round-trips the whole protocol corpus.test_fixtures.pyround-trips thereq_*frames and only decodes eachresp_*frame to itstype(anddata).protocol/README.mdalready describes this correctly, and the three texts now match it.sdk/python/e2e.py,sdk/openai/e2e.pyandmcp/e2e.pynamed--template rt2:24.04, an image no build in this repo produces. They now sayrt:24.04, the default every other example uses.LOOPBACK_PORTdoc. It namedproxy.internal:3128. Guests reach the proxy at127.0.0.1:3128(the base unit'shttp_proxy), andproxy.internalexists only as a placeholder host in an outbound test.Checks:
ruff format --checkandruff checkare clean (39 files).cargo fmt --checkin silkd is clean. The comment-line delta is +1/−1.