Repository navigation
sdk/python: the upgrade fake stops listening once it accepts - #533
Merged
Merged
Conversation
A refused upgrade rebinds the handle, and its peers lookup queued on the fake's still-open listener until two 5 s timeouts ran out. Closing the listener makes the lookup fail at once: test_upgrade.py drops from 20.3 s to 0.22 s and the SDK suite from ~87 s to ~65 s on python:3.10.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A refused upgrade (404) rebinds the sandbox handle. The rebind's peers lookup connects to the fake agent's listener, which is still open but no longer accepting, so the lookup waits out two 5 s timeouts. Each of the two
test_rejected_upgrade_is_an_api_errorcases took 10.00 s.The fake now closes its listener right after
accept, so the lookup is refused at once. The assertions are unchanged.Measured in python:3.10, with the arms interleaved base, patch, patch, base:
tests/test_upgrade.pysdk/pythonsuiteAll 294 tests pass in both arms.
ruff format --checkandruff checkare clean.