Repository navigation
review: audit cleanups - #523
Merged
Merged
Conversation
Static and runtime catalogs now share one tenant name check; an invalid static name used to load and match no tenant.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Whole-repo static audit of main 90cacf1. Every tracked file was read in full: sandboxd, silkd, boot/init, protocol/wire, the Go/Python SDKs and adapters, mcp, e2e, scripts, os-image, CI and docs. No correctness defects were found. The docs were cross-checked against the code: the config table, reload classes, API status codes, silkd verb limits and egress-lane restrictions all match.
Behavior change:
config.ValidateVolumeCatalognow checks static volumetenantsnames against the tenant API syntax. A config holding an invalid name fails to load; it used to load and match no tenant. Runtime registration already ran this check and now shares the same code. The access-list doc and an Upgrading note are updated.Changes (no behavior change):
sandboxd/types/types.go: the unexportedenvView/namedVarnow follow the exported vocabulary types.routeFuncin mcp; the existingconnHandlerin sdk/go).managerEditsits with the other test func types.protocol/wire/frame.go:responseHeadis now the one spelling of the response tag head, used byEncodeResponseandrespTagHead.outbound.Host.RearmTunreturns for a claim without doors before resolving its policy.View/Resolveare side-effect free.protocol/wireas the corpus test's home.Gates were not run locally, by the owner's instruction for this round, so CI on this PR is the evidence.