review: one scheme builder and one namespace helper for the bench harnesses - #14
Merged
Conversation
…nesses l2bench and scalebench each built the same scheme; e2ebench, scalestress and poolbench each created their run namespace the same way. Both move into test/benchutil, which the harnesses already import.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
test/benchutilgainsNewScheme(extra ...func(*runtime.Scheme) error)andEnsureNamespace(ctx, cl, name, labels);l2bench/scalebenchdrop their privatenewScheme,e2ebench/scalestress/poolbenchdrop their privateensureNS. Net −11 lines, harness code only (every harness is build-tagged; nothing underpkg/,controllers/orinternal/changes).Evidence
GOWORK=off go build -tags <tag> ./test/<tag>/for l2bench, scalebench, e2ebench, scalestress, poolbench: all build.make lintGOOS=darwin and GOOS=linux: 0 issues;make fmt-check: clean;asl ./...both GOOS: clean.go test -race ./test/benchutil/ ./internal/...: ok.