refactor: scope host details extractor to vmware only - #1166
Merged
Conversation
SoWieMarkus
requested review from
PhilippMatthes,
auhlig,
juliusclausnitzer,
mblos and
umswmayj
as code owners
August 26, 2026 14:43
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (14)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review. 📝 WalkthroughWalkthroughThe host-details extractor is now VMware-specific. Its SQL excludes KVM and ironic hosts. The knowledge resource, extractor registry, Helm dependencies, KPI consumers, models, and tests use VMware-specific names and types. ChangesVMware host knowledge flow
Estimated code review effort: 3 (Moderate) | ~20 minutes Merge Risk: ⚪ Minimal · up to The change narrows host details to VMware hosts and updates the related consumers and deployment configuration consistently. No actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant PlacementData
participant VMwareHostDetailsExtractor
participant KnowledgeResource
participant InfrastructureKPIs
PlacementData->>VMwareHostDetailsExtractor: Query host and inventory data
VMwareHostDetailsExtractor->>KnowledgeResource: Publish VMware host details
InfrastructureKPIs->>KnowledgeResource: Read vmware-host-details
KnowledgeResource-->>InfrastructureKPIs: Return VMwareHostDetails
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 15 functions across 10 files. (3 skipped: 3 unsupported.)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
PhilippMatthes
previously approved these changes
Aug 26, 2026
stack merge was automatically disabled
August 27, 2026 08:51
Pull Request is not mergeable
SoWieMarkus
force-pushed
the
feat/host-details-rebrand
branch
from
August 27, 2026 08:52
b9456a8 to
27f26cc
Compare
Signed-off-by: Markus Wieland <markus.wieland@sap.com>
Signed-off-by: Markus Wieland <markus.wieland@sap.com>
SoWieMarkus
force-pushed
the
feat/host-details-rebrand
branch
from
August 27, 2026 08:57
27f26cc to
38438bd
Compare
Contributor
Test Coverage ReportTest Coverage 📊: 72.4% |
umswmayj
approved these changes
Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebrands the
host-detailsknowledge tovmware-host-detailsand scopes it to VMware hosts only. KVM hosts are served by a dedicated CRD and ironic hosts are not needed, so both are now excluded directly in the extractor SQL rather than filtered in the KPIs.