Conversation
Lightweight, hermetic unit tests (no real forge-io / OIIO needed — conftest stubs forge_io when absent; functions under test are monkeypatched so no decode runs). Locks down the regressions from the forge-io v0.5.0/v0.6.0 work: - .mxf routes to read_container_frame (forge-io, essence-classified), NOT a bespoke ffmpeg fallback; the fallback symbols are asserted gone. - .r3d → raw clip; .mov/.mp4/.m4v/.avi/.mkv → container; sequences otherwise; case-insensitive; path/frame/assume_source threaded through unchanged. - read_container_frame forwards frame_index + assume_source + the sRGB working_space default into forge_io.read; missing file raises. Adds [tool.pytest.ini_options] testpaths=["tests"]. 16 tests, pass in the forge env and with forge_io blocked (CI-safe). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the first unit tests to forge-align — lightweight guards for the solver's extension dispatch and container kwarg-forwarding, locking down the regressions introduced by the forge-io v0.5.0/v0.6.0 integration.
What's covered
.mxf→read_container_frame(forge-io, essence-classified) — the regression, since.mxfused to hit a bespoke ffmpeg fallback that was removed. Also asserts the fallback symbols (extract_container_frame,_FFMPEG_CONTAINER_EXTS) are gone..r3d→ raw clip;.mov/.mp4/.m4v/.avi/.mkv→ container; everything else → sequence; case-insensitive;path/frame_idx/assume_sourcethreaded through unchanged.read_container_frameforwardsframe_index+assume_source+ thesRGBworking_spacedefault intoforge_io.read; missing file raisesFileNotFoundError.Hermetic by design
tests/conftest.pystubsforge_iowhen it isn't importable, and every function under test is monkeypatched — no real decode, no OIIO/OCIO needed. Verified passing three ways: in theforgeenv (real forge-io), in base python, and withforge_ioactively blocked (proves CI-safety). 16 tests, ~0.01s.Adds
[tool.pytest.ini_options] testpaths=["tests"]. No production code touched.🤖 Generated with Claude Code