Repository navigation
fix(architectures): list the Envoy project once in the project filter - #2107
Merged
Merged
Conversation
The project filter on /architectures and /community/members offers one option per distinct `projects` label. The Swisscom Kubernetes Service page files the CNCF Envoy project under "Envoy Gateway". A page that lists the project as "Envoy", the name CNCF publishes, would add a second option for the same project, and the catalog test "no CNCF project is listed under two labels across the catalog" would fail, because both pages' cards link to https://www.cncf.io/projects/envoy/. Following cncf#2022, this normalizes the front matter label to Envoy and updates the generated catalog and member data to match. The page's own card still names Envoy Gateway, so the detail its authors wrote is kept. Signed-off-by: Ahmed Bebars <1381372+abebars@users.noreply.github.com>
✅ Deploy Preview for endusers ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
The two-label guard mapped a catalog label to a CNCF project only when a card carried that exact name. With the Swisscom page filed under Envoy while its card names Envoy Gateway, the Envoy label had no slug, dropped out of the check, and a later page filed under Envoy Gateway would split the filter again undetected. A label that spells the slug of a linked project now resolves to that project, and the guard asserts the Envoy label is covered. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
Test prose may not cite issue or pull request numbers (ADR 0006). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The project filter on /architectures and /community/members offers one option per distinct
projectslabel. The Swisscom Kubernetes Service page files the CNCF Envoy project under "Envoy Gateway". A page that lists the project as "Envoy", the name CNCF publishes, would add a second option for the same project, and the catalog test "no CNCF project is listed under two labels across the catalog" would fail, because both pages' cards link to https://www.cncf.io/projects/envoy/.Following #2022, this normalizes the front matter label to Envoy and updates the generated catalog and member data to match. The page's own card still names Envoy Gateway, so the detail its authors wrote is kept.