Repository navigation
ci: let the metrics refresh read cncf/tab issues - #2103
Merged
Merged
Conversation
Every refresh of data/metrics.json committed by the Refresh metrics workflow has published 0 open reference architecture submissions and a 0-day median age (2026-09-24, 2026-11-03), while every run of the same collector from a maintainer's shell published the real count (13). The workflow pins GITHUB_TOKEN to `contents: write` and `pull-requests: write` and grants no issues permission. GET /repos/cncf/tab/issues returns both issues and pull requests, and a token with only pull request access sees only the pull request entries; the collector drops those with `!item.pull_request`, leaving nothing to count. Grant `issues: read` so the listing is complete. Remit: /resources/metrics publishes a 0 open submissions card and a 0-day median against a dozen open cncf/tab submissions after each automated refresh. Refs #1878 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com>
✅ Deploy Preview for endusers ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every refresh of
data/metrics.jsoncommitted by the Refresh metrics workflow has published 0 open reference architecture submissions and a 0-day median age (b5cf9ffon 2026-09-24, and #2100 today), while every run of the same collector from a maintainer's shell published the real count (13 then, 12 now). #1878 fixed the symptom by re-running the lane by hand; this is the cause.refresh-metrics.ymlpinsGITHUB_TOKENtocontents: writeandpull-requests: writeand grants noissuespermission.GET /repos/cncf/tab/issuesreturns both issues and pull requests, and a token with only pull request access sees only the pull request entries.collectLifecycleMetrics()drops those with!item.pull_request, leaving nothing to count, so the lane publishes zeros without any error. The architecture PR cards fromcncf/architecture/pullswere unaffected, which is why the rest of the panel looked right.Remit:
/resources/metricspublishes a 0 open submissions card and a 0-day median against a dozen open cncf/tab submissions after each automated refresh.What changed
issues: readadded to the workflow'spermissions, with a comment recording why. No collector change.Verification
gh workflow run refresh-metrics.ymltoday (run 41690320039) wroteopen-submissions: 0; the samegithubAllPagescall from a shell returns 169 issues, 26 labelled, 12 open.node --test tests/ci-supply-chain.test.mjs tests/refresh-script-wiring.test.mjs tests/automation-workflow-ordering.test.mjs tests/ci-concurrency.test.mjs: 57 pass.open-submissions: 12before merging it.Refs #1878