Repository navigation
Update to reactphp/http v1.10.0 and drop dated ringcentral/psr7 dependency - #66
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The replacement preserves the existing constructor and request interface contract, and the dependency constraints align with the change.
No open issues 🎉
What changed in this PR
This PR fixes SOAP request failures on fresh installs using react/http 1.10 or later by replacing the removed RingCentral request implementation with ReactPHP’s implementation.
Changes:
- Switch
ClientEncodertoReact\Http\Message\Request. - Raise the minimum react/http version to 1.10 and remove the temporary ringcentral/psr7 development dependency.
| File | Description |
|---|---|
| src/Protocol/ClientEncoder.php | Use ReactPHP’s request class for SOAP requests. |
| composer.json | Require react/http ^1.10 and remove ringcentral/psr7. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This changeset updates to reactphp/http
v1.10.0and drops the dated ringcentral/psr7 dependency. TheClientEncodernow uses theReact\Http\Message\Requestclass from reactphp/http instead ofRingCentral\Psr7\Request, which reactphp/http no longer installs as ofv1.10.0. The import was added with #19 back in 2016, and since that release in March 2024 every SOAP request on a fresh install fails withClass "RingCentral\Psr7\Request" not found.The new
Requestclass takes the same arguments, so this should be safe to apply. This also removes the ringcentral/psr7 requirement that #65 temporarily added for the tests.Builds on top of #65, #19, #56, #45, reactphp/http#522, reactphp/http#519 and reactphp/http#480
Refs clue/reactphp-http-proxy#65