Skip to content

Update to reactphp/http v1.10.0 and drop dated ringcentral/psr7 dependency - #66

Merged
clue merged 1 commit into
clue:mainfrom
clue-labs:update-http
Oct 25, 2026
Merged

clue merged 1 commit into
clue:mainfrom
clue-labs:update-http

Conversation

@clue

@clue clue commented Oct 25, 2026

Copy link
Copy Markdown
Owner

This changeset updates to reactphp/http v1.10.0 and drops the dated ringcentral/psr7 dependency. The ClientEncoder now uses the React\Http\Message\Request class from reactphp/http instead of RingCentral\Psr7\Request, which reactphp/http no longer installs as of v1.10.0. The import was added with #19 back in 2016, and since that release in March 2024 every SOAP request on a fresh install fails with Class "RingCentral\Psr7\Request" not found.

The new Request class takes the same arguments, so this should be safe to apply. This also removes the ringcentral/psr7 requirement that #65 temporarily added for the tests.

Builds on top of #65, #19, #56, #45, reactphp/http#522, reactphp/http#519 and reactphp/http#480
Refs clue/reactphp-http-proxy#65

@clue clue added this to the v2.1.0 milestone Oct 25, 2026
@clue
clue requested a balanced review from Copilot October 25, 2026 11:30

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The replacement preserves the existing constructor and request interface contract, and the dependency constraints align with the change.

No open issues 🎉

What changed in this PR

This PR fixes SOAP request failures on fresh installs using react/http 1.10 or later by replacing the removed RingCentral request implementation with ReactPHP’s implementation.

Changes:

  • Switch ClientEncoder to React\Http\Message\Request.
  • Raise the minimum react/http version to 1.10 and remove the temporary ringcentral/psr7 development dependency.
File Description
src/​Protocol/​ClientEncoder.php Use ReactPHP’s request class for SOAP requests.
composer.json Require react/http ^1.10 and remove ringcentral/psr7.

Review effort: Balanced

@clue
clue merged commit ccfe3f6 into clue:main Oct 25, 2026
3 checks passed
@clue
clue deleted the update-http branch October 25, 2026 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants