feat: Animate side navigation collapse and expandable section reveal - #4867
Open
jkuelz wants to merge 5 commits into
Open
feat: Animate side navigation collapse and expandable section reveal#4867jkuelz wants to merge 5 commits into
jkuelz wants to merge 5 commits into
Conversation
Replace the display:none content toggle in ExpandableSection with a grid-template-rows reveal, and animate the SideNavigation collapse/expand: text fades while icons stay centered, spatial and opacity transitions are staggered with tunable local timing vars, groups get collapsed-state spacing, and hidden content is inert for accessibility. WIP checkpoint on dev-v3-jkuelz-side-nav-animations-refactor so the existing icon-layout PR stays clean.
…stacking with nested groups
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Animates
SideNavigation's collapsed icon rail transition andExpandableSection's content reveal, scoped to 1T only as per the animation strategy and to prevent breaking changes.ExpandableSection'sdisplay: none/blockcontent toggle with an animatedgrid-template-rowsreveal. The content stays mounted and inert while collapsed, to allow for smooth transition states that weren't possible with the previousdisplay: none.grid-template-rowsstrategy as expandable sections to enable transitions: text fade, spatial collapse/expand, and staggered enter/exit timing for links, sections, section-groups, link-groups, and expandable-link-groups.Other behavior changes:
inert(not just visual hiding) to remove their headers/parent links from the tab order and assistive technology when they collapse to zero size in the rail.ariaLabelplumbing andaria-hiddenon section/section-group header text for collapsed-rail accessibility.Why animations only in 1T?
The initial version of this animation applied to all themes and broke the pre-existing contract for ExpandableSection that collapsed/hidden content is visually removed instantly (display: none) — which means any downstream tests that asserted isDisplayed()/isExisting() immediately after a collapse toggle with no wait, could fail. Scoping the animation to one-theme (opt-in) avoids that regression for existing VR/classic consumers while still shipping the new motion for one-theme.
Related links, issue #, if available: n/a
How has this been tested?
dev pipeline
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.