Skip to content

fix: Update disabled normal button text color for a11y contrast - #4861

Open
ywyyu17 wants to merge 2 commits into
mainfrom
dev-v3-ywy
Open

fix: Update disabled normal button text color for a11y contrast#4861
ywyyu17 wants to merge 2 commits into
mainfrom
dev-v3-ywy

Conversation

@ywyyu17

@ywyyu17 ywyyu17 commented Aug 3, 2026

Copy link
Copy Markdown

Description

Issue

11b Button dropdown - Main action
Loading spinners in normal variant buttons have a color contrast ratio below 3:1.

Foreground color: #A9A9A9
Background color: #FFFFFF
Contrast ratio: 2.35:1

Fix

Update color to use grey500 instead of grey450

How has this been tested?

manual test
pending screenshot test

@codecov

codecov Bot commented Aug 3, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.63%. Comparing base (154aba5) to head (2b50171).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4861   +/-   ##
=======================================
  Coverage   97.63%   97.63%           
=======================================
  Files         957      957           
  Lines       31097    31097           
  Branches    11435    11435           
=======================================
  Hits        30361    30361           
  Misses        689      689           
  Partials       47       47           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants