fix: Retry plugin downloads that drop mid-body - #672
Open
erezrokah wants to merge 2 commits into
Open
Conversation
An HTTP/2 INTERNAL_ERROR stream reset during the body copy was classified as permanent, so the download failed after a single attempt. Classify transient transport failures and retryable status codes for retry, keep 4xx permanent, reset the output file between attempts, verify the body length against Content-Length, and extract the plugin binary through a temporary file so a partial extraction is never cached as a plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Retries a mid-body HTTP/2 stream reset and its sibling transient transport failures within a bounded budget, while keeping 4xx permanent so an expired signed URL fails fast.
#1— one attempt. The body-copy error did not match the oldRetryIf, which only accepted a non-200 status.