Skip to content

chore(ui): ux docs modal action button labels - #1925

Merged
franzheidl merged 2 commits into
mainfrom
franz-ux-docs-modal-action-button-labels-1923
Aug 27, 2026
Merged

chore(ui): ux docs modal action button labels #1925
franzheidl merged 2 commits into
mainfrom
franz-ux-docs-modal-action-button-labels-1923

Conversation

@franzheidl

Copy link
Copy Markdown
Member

Summary

Clarify guideliens for labels on Modal confirming action buttons, update stories accordingly.

Related Issues

Closes #1923

Checklist

  • I have performed a self-review of my code.
  • I have commented my code, particularly in hard-to-understand areas.
  • I have added tests that prove my fix is effective or that my feature works.
  • New and existing unit tests pass locally with my changes.
  • I have made corresponding changes to the documentation (if applicable).
  • My changes generate no new warnings or errors.
  • I have created a changeset for my changes.

PR Manifesto

Review the PR Manifesto for best practises.

…tton labels

Signed-off-by: Franz Heidl <franz.heidl@sap.com>
Signed-off-by: Franz Heidl <franz.heidl@sap.com>
@franzheidl franzheidl self-assigned this Aug 27, 2026
@franzheidl franzheidl added the documentation Improvements or additions to documentation label Aug 27, 2026
@changeset-bot

changeset-bot Bot commented Aug 27, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9723b1f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Aug 27, 2026

Copy link
Copy Markdown
Contributor
PR Preview Action v1.8.1
Preview removed because the pull request was closed.
2026-08-27 13:56 UTC

@franzheidl
franzheidl marked this pull request as ready for review August 27, 2026 13:46
@franzheidl
franzheidl requested a review from a team as a code owner August 27, 2026 13:46
Copilot AI lite review requested due to automatic review settings August 27, 2026 13:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the UX writing guidelines and Storybook Modal examples to clarify/standardize confirming action button labels (per #1923), including title-casing “Register Now” in existing Modal stories.

Changes:

  • Updated Modal form stories to use confirmButtonLabel: "Register Now" (capitalized “Now”).
  • Expanded UX writing guidelines with a new section on confirming buttons in modals, with “Do” and fallback examples.
  • Adjusted the “button label in copy” example formatting.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/ui-components/src/components/Modal/Modal.stories.tsx Aligns Modal confirm button label casing with the updated writing guidance/issue requirements.
docs/ux/ux-writing-content-design.md Adds clearer guidance for Modal confirming button labels and supporting examples.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread docs/ux/ux-writing-content-design.md
@franzheidl
franzheidl merged commit 3d04f1f into main Aug 27, 2026
29 checks passed
@franzheidl
franzheidl deleted the franz-ux-docs-modal-action-button-labels-1923 branch August 27, 2026 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Task](ui): ux docs – provide more clarity re Modal confirming action button labels

4 participants