Add int64 format annnotation for log_rate_limit_in_bytes_per_second - #5453
Open
praveenrewar wants to merge 1 commit into
Open
praveenrewar wants to merge 1 commit into
praveenrewar wants to merge 1 commit into
Conversation
In 32-bit systems and in languages like java, int primitive is 32 bits, and a value larger than 2G will cause integer overflow, hence any java client should use int64 explicitly for this field Signed-off-by: Praveen Rewar <8457124+praveenrewar@users.noreply.github.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add int64 format annnotation for log_rate_limit_in_bytes_per_second
In 32-bit systems and in languages like java,
int primitive is 32 bits, and a value larger than 2G for log_rate_limit_in_bytes_per_second will cause integer overflow, hence any java client should use int64 explicitly for this field.