default director.use_bpm_for_workers to false

[mkocher]

Using bpm for workers breaks using heavy stemcells on AWS as the destination volume gets mounted to the director to get the stemcell bits copied to it.

What tests have you run against this PR?

bundle exec rake spec:unit:release

How should this change be described in bosh release notes?

Fix: director.use_bpm_for_workers now defaults to false. This fixes using heavy stemcells with the AWS CPI.

Does this PR introduce a breaking change?

No

Tag your pair, your PM, and/or team!

@ragaskar @KauzClay

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: cd7e0318-46f4-443f-a263-b089315a95f4

📥 Commits

Reviewing files that changed from the base of the PR and between ed8e360 and 7fe9af2.

📒 Files selected for processing (2)

• jobs/director/spec
• spec/director_templates_spec.rb

---

Walkthrough

The director specification changes director.use_bpm_for_workers to default to false and shortens its description. Director template specs verify that worker processes are absent by default and validate BPM worker generation when enabled, including queues, executables, disk mounts, dynamic-disks workers, CPI job volumes, additional volumes, and unrestricted volume handling.

Suggested reviewers: aramprice

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title accurately summarizes the main change: defaulting director.use_bpm_for_workers to false.
Description check	✅ Passed	The description covers the change, tests, release notes, breaking change status, and tags, though contextual links and AI review feedback are missing.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch disable-bpm-workers-default

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}