jammy => noble - #678
Merged
Merged
Conversation
nit: config script uses fly var
The smoke manifest declares bpm as a required release (added in ba67a70), but the BeforeSuite was missed in that commit — only the parallel syslogrelease/smoke_suite_test.go was updated. This caused 'Release bpm doesn't exist' during deploy. While here, drop os-conf upload: the smoke manifest never references os-conf, so uploading it added a redundant compile/upload step.
Contributor
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
aramprice
requested review from
a team,
mkocher and
selzoc
and removed request for
a team
June 30, 2026 01:57
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@acceptance-tests/ipv4director/smoke/smoke_suite_test.go`:
- Around line 25-29: Remove the remaining OS_CONF_RELEASE_PATH dependency by
updating the auditd smoke suite to use BPM_RELEASE_PATH like the other suites,
and delete the legacy OS_CONF_RELEASE_PATH export from the test-stemcell task.
Check the setup code in the auditd smoke test around the RequireEnv calls and
the environment exports in ci/tasks/test-stemcell.sh so the remaining release
upload path only uses BPM-related naming.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 073bfd68-ee3f-43e3-aae5-e12a5d98bf03
⛔ Files ignored due to path filters (4)
Gemfile.lockis excluded by!**/*.lockacceptance-tests/go.sumis excluded by!**/*.sumvendor/package/json-2.19.9.gemis excluded by!vendor/**vendor/package/json-2.20.0.gemis excluded by!vendor/**
📒 Files selected for processing (19)
acceptance-tests/go.modacceptance-tests/ipv4director/smoke/smoke_suite_test.goacceptance-tests/vendor/github.com/onsi/ginkgo/v2/CHANGELOG.mdacceptance-tests/vendor/github.com/onsi/ginkgo/v2/README.mdacceptance-tests/vendor/github.com/onsi/ginkgo/v2/types/version.goacceptance-tests/vendor/github.com/onsi/gomega/CHANGELOG.mdacceptance-tests/vendor/github.com/onsi/gomega/gomega_dsl.goacceptance-tests/vendor/modules.txtci/configure.shimage-metalinks/ubuntu-jammy/ubuntu-jammy.meta4stemcell_builder/stages/blobstore_clis/assets/bosh-blobstore-azure-storage.sha256sumstemcell_builder/stages/blobstore_clis/assets/bosh-blobstore-azure-storage.urlstemcell_builder/stages/blobstore_clis/assets/bosh-blobstore-azure-storage.versionstemcell_builder/stages/blobstore_clis/assets/bosh-blobstore-dav.sha256sumstemcell_builder/stages/blobstore_clis/assets/bosh-blobstore-dav.urlstemcell_builder/stages/blobstore_clis/assets/bosh-blobstore-dav.versionstemcell_builder/stages/blobstore_clis/assets/bosh-blobstore-s3.sha256sumstemcell_builder/stages/blobstore_clis/assets/bosh-blobstore-s3.urlstemcell_builder/stages/blobstore_clis/assets/bosh-blobstore-s3.version
cf-foundation-community-automation
Bot
moved this to Inbox
in Foundational Infrastructure Working Group
github-project-automation
Bot
moved this from Inbox
to Pending Merge | Prioritized
in Foundational Infrastructure Working Group
neddp
previously approved these changes
Jun 30, 2026
ystros
approved these changes
Jun 30, 2026
github-project-automation
Bot
moved this from Pending Merge | Prioritized
to Done
in Foundational Infrastructure Working Group
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: this repository uses a "Merge Forward" strategy
Changes should be made in the earliest applicable branch, and
merged forward through subsequent branches.
ubuntu-<short_name-N>ubuntu-<short_name-N>intoubuntu-<short_name-N+1>