Repository navigation
[vite-plugin] Update v1 Playwright for Ubuntu 26.04 - #16632
Conversation
petebacondarwin
added
ci:no-changeset-required
|
commit: |
|
LGTM |
|
@petebacondarwin (verified original author) @edmundhung (verified human ant-core approver): please check this v1 backport of #16622 and approve it if it looks good. This replaces the empty #16627 record. I verified this PR contains one actual backport commit (ca9bb25) and exactly the Playwright catalog/lockfile diff directly against vite-plugin-v1, including after stack creation. #16580 and #16601 now follow it. The tree matches the validated standalone root: frozen install, build/types/all58 checks, all8 package test tasks and all6 fixture tasks including real browser tests pass. The update supplies Ubuntu 26.04 browser installation support for retained v1 CI consumers; no test-only changeset is needed. The original comment on #16627 cannot cover review of this replacement PR. |
|
Codeowners approval required for this PR:
|
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![clanky-the-clanker[bot]](https://avatars.githubusercontent.com/in/5306670?s=60&v=4){kind=small}
There was a problem hiding this comment.
✅ Approved — This pull request only bumps the catalog pins for @playwright/test and playwright-chromium from 1.60.0 to 1.61.0, and the lockfile changes match: playwright, playwright-core and both packages move together. No issues found.
The decision is advisory: this review is a comment and never approves, blocks or requests changes on the pull request.
✅ All checks passed
📋 Code Quality: ✅ LGTM
The pnpm-workspace.yaml catalog changes @playwright/test and playwright-chromium from 1.60.0 to 1.61.0. In pnpm-lock.yaml, every Playwright entry moves to 1.61.0 together: the importer specifiers, @playwright/test, playwright, playwright-core and playwright-chromium, each with a new integrity hash. No other packages change, and the private workspace:* dependencies are left as they were.
📝 Documentation: ✅ LGTM
This pull request changes only test dependency versions, so no documentation or changeset is needed.
Reviewed commit: ca9bb259
workers-devprod
left a comment
workers-devprod
left a comment
There was a problem hiding this comment.
Codeowners reviews satisfied
Backports #16622 directly onto
vite-plugin-v1. This replaces #16627, which was incorrectly marked merged with zero commits and zero changed files during the earlier stack reorder. That PR did not supply the V1 fix.The backport commit updates the shared
@playwright/testandplaywright-chromiumpins from 1.60.0 to 1.61.0 and regenerates the V1 lockfile. V1's retained playground and test-harness workflows install Chromium onubuntu-latest; Playwright 1.61 supports Ubuntu 26.04 so those jobs can continue running as the image rolls forward. The independently useful diff is one commit and two files (+23/-23), with no runtime, auth or public package source changes. Private workspace dependencies remain intact. No changeset is needed for test dependency pins.This is the root backport; #16580 (runtime) and #16601 (publication-blocked auth draft) follow it. The prior empty PR is not counted as original or dependency-version coverage.
Validation: the root tree is byte-identical to the standalone root validated with Node 22.22.1 / pnpm 10.33.0: genuine frozen install;
pnpm check(58 tasks including build/types);pnpm test:ci(8 tasks including 231 plugin tests);pnpm test:fixtures(6 tasks including 30 dev-registry tests, 5 Vitest harness tests and 2 real Playwright browser tests). Diff checks pass. Browser validation ran on macOS; Ubuntu 26.04 and the full OS/Vite matrix remain CI checks. Both local Git and GitHub comparisons must show one commit and exactlypnpm-workspace.yamlpluspnpm-lock.yamlagainst the actual V1 branch before readiness.Note
This is a contribution from an AI agent: Codex, under the authorized v1 backport automation.