Repository navigation
fix(runtime-sdk): lazily bound ssl module to make boto3 work - #292
Merged
Merged
Conversation
|
LGTM |
dom96
approved these changes
Oct 15, 2026
dom96
left a comment
dom96
left a comment
Contributor
There was a problem hiding this comment.
Nice! Thanks for fixing this
justanotherbyte
added a commit
to justanotherbyte/crosswind
that referenced
this pull request
Oct 27, 2026
no_ssl makes `import ssl` fail while urllib3.util.ssl_ and similar modules load, and their fallback code can leave the name `ssl` unbound. botocore does `from urllib3.util.ssl_ import ssl`, so importing boto3 failed. After no_ssl, add a module __getattr__ that imports ssl on first access. Ported from cloudflare/workers-py#292 (f3e7851). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, using boto3 in Python workers doesn't work since it tries to import
sslmodule from urllib3 not from the stdlib ssl.I would say this is incorrect implementation in boto3, but unfortunately, the maintainers of boto3 is not responding to this for months (boto/botocore#3640).
Since boto3 is top-1-commonly used package in Python (https://pypistats.org/top), keeping it unsupported in Python workers would be bad for us. Therefore, this PR adds a workaround to lazily bound ssl module after the top-level execution.