fix: preserve unknown RPC return types - #7168
Open
nanookclaw wants to merge 1 commit into
Open
Conversation
|
I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
Author
|
I have read the CLA Document and I hereby sign the CLA |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5200.
Rpc.Result<R>currently falls through toneverwhenRisunknown. The same failure affects concrete object types containing unknown fields, such as{ bar: unknown[] }, even though those values can be carried over the RPC boundary.This adds an
unknown extends Tbranch toSerializable<T>. The guard acceptsunknownonly when it is the type being checked; known types continue through the existing recursive serializability checks. Existing rejection of known non-serializable values, includingReadableStream<string>, is preserved. Type-level coverage now exercises both the top-level and nested-unknown cases.Verification
git diff --checkReadableStream<string>rejection.