Re-enable clang-tidy for the workerd-api library - #7167
Draft
sohpeach wants to merge 2 commits into
Draft
Conversation
![ask-bonk[bot]](https://avatars.githubusercontent.com/in/2454580?s=60&v=4){kind=small}
Comment on lines
-177
to
-178
| # TODO(soon): This is temporarily disabled because it takes a lifetime to complete. | ||
| tags = ["no-clang-tidy"], |
Contributor
There was a problem hiding this comment.
P1: Re-enabling this immediately restores the documented unbounded clang-tidy run time. The required lint / bazel job has remained in its Bazel build step for over ten minutes while the comparable Linux and macOS build jobs have completed, so this blocks the required lint check rather than making the target checked. Keep the opt-out until the slow analysis has been fixed and verified.
Suggested change
| # TODO(soon): This is temporarily disabled because it takes a lifetime to complete. | |
| tags = ["no-clang-tidy"], | |
| # TODO(soon): This is temporarily disabled because it takes a lifetime to complete. | |
| tags = ["no-clang-tidy"], |
Contributor
|
I'm Bonk, and I've done a quick review of your PR. Re-enables clang-tidy for
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft because broken