Fix EventSource use-after-free - #7166
Merged
sohpeach merged 1 commit intoAug 28, 2026
Merged
Conversation
erikcorry
approved these changes
Aug 28, 2026
sohpeach
force-pushed
the
swallace/patch-eventsource-uaf
branch
from
August 28, 2026 09:51
b858645 to
929931c
Compare
Contributor
|
@sohpeach Bonk workflow was cancelled. View workflow run · To retry, trigger Bonk again. |
sohpeach
force-pushed
the
swallace/patch-eventsource-uaf
branch
from
August 28, 2026 10:55
929931c to
ebe27d6
Compare
EventSourceSink queued a gated callback capturing a raw EventSource pointer. If the EventSource was collected before callback execution, the callback dereferenced freed native memory. Carry a weak EventSource reference through the sink and promote it under the isolate lock before dispatch.
sohpeach
force-pushed
the
swallace/patch-eventsource-uaf
branch
from
August 28, 2026 11:39
ebe27d6 to
1883e0f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merging from upstream.
EventSourceSink queued a gated callback capturing a raw EventSource pointer. If the EventSource was collected before callback execution, the callback dereferenced freed native memory.
Carry a weak EventSource reference through the sink and promote it under the isolate lock before dispatch.